Skip to content

List: fix pronunciation an item when using TalkBack on Android (T1326682)#33316

Open
pharret31 wants to merge 4 commits intoDevExpress:26_1from
pharret31:26_1_3941-list-it-is-not-possible-to-select-and-pronounce-an-item-when-using-talkback-on-android-t1326682
Open

List: fix pronunciation an item when using TalkBack on Android (T1326682)#33316
pharret31 wants to merge 4 commits intoDevExpress:26_1from
pharret31:26_1_3941-list-it-is-not-possible-to-select-and-pronounce-an-item-when-using-talkback-on-android-t1326682

Conversation

@pharret31
Copy link
Copy Markdown
Contributor

No description provided.

@pharret31 pharret31 self-assigned this Apr 16, 2026
@pharret31 pharret31 requested a review from a team as a code owner April 16, 2026 12:35
Copilot AI review requested due to automatic review settings April 16, 2026 12:35
@pharret31 pharret31 added the 26_1 label Apr 16, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets improved accessibility behavior for dxList, specifically addressing incorrect item pronunciation in Android TalkBack scenarios by making list items programmatically focusable and keeping widget focus state in sync.

Changes:

  • Add tabindex="-1" to default list item attributes (alongside role="option").
  • Add a ListBase-specific _handleItemFocus to update focusedElement when an item receives focus and then restore DOM focus to the list’s focus target.
  • Update/extend QUnit accessibility and keyboard-navigation tests to assert tabindex="-1" and the new focus behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/js/__internal/ui/list/list.base.ts Adds tabindex="-1" to item attributes and overrides _handleItemFocus to sync focusedElement + restore focus target.
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js Adds keyboard-navigation tests asserting item attributes and focus behavior after pointer interaction.
packages/devextreme/testing/tests/DevExpress.ui.widgets/list.markup.tests.js Updates ARIA/markup expectations to include tabindex="-1" on list items.

Comment thread packages/devextreme/js/__internal/ui/list/list.base.ts
Copilot AI review requested due to automatic review settings April 16, 2026 13:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants