Skip to content

Scheduler - Move scroll position update from Popup to Scheduler#33322

Open
aleksei-semikozov wants to merge 1 commit intoDevExpress:26_1from
aleksei-semikozov:scheduler-move-scroll-to-scheduler-v2
Open

Scheduler - Move scroll position update from Popup to Scheduler#33322
aleksei-semikozov wants to merge 1 commit intoDevExpress:26_1from
aleksei-semikozov:scheduler-move-scroll-to-scheduler-v2

Conversation

@aleksei-semikozov
Copy link
Copy Markdown
Contributor

No description provided.

@aleksei-semikozov aleksei-semikozov self-assigned this Apr 16, 2026
@aleksei-semikozov aleksei-semikozov marked this pull request as ready for review April 16, 2026 17:52
@aleksei-semikozov aleksei-semikozov requested a review from a team as a code owner April 16, 2026 17:52
Copilot AI review requested due to automatic review settings April 16, 2026 17:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves the “scroll to edited/created appointment” behavior from the AppointmentPopup layer into the Scheduler widget, so the Scheduler owns the post-save scrolling behavior.

Changes:

  • Added Scheduler.scrollToAppointment(...) and invoke it after successful add/update from the popup save callback.
  • Removed popup-side “last saved edit data” state and the popup-driven scroll update logic.
  • Added a Jest test to verify scrolling occurs after saving from the appointment popup.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/devextreme/js/__internal/scheduler/m_scheduler.ts Adds centralized scroll-to-appointment logic in Scheduler and hooks it into popup save flows.
packages/devextreme/js/__internal/scheduler/appointment_popup/m_popup.ts Removes popup-managed scroll behavior and related state, leaving save flow focused on validation + persistence.
packages/devextreme/js/__internal/scheduler/tests/scheduler.test.ts Adds coverage to ensure saving from the popup triggers scrolling to the appointment position.
packages/devextreme/js/__internal/scheduler/tests/mock/create_appointment_popup.ts Updates the popup test mock surface to reflect removal of scroll update plumbing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants