Scheduler - Move scroll position update from Popup to Scheduler#33322
Open
aleksei-semikozov wants to merge 1 commit intoDevExpress:26_1from
Open
Scheduler - Move scroll position update from Popup to Scheduler#33322aleksei-semikozov wants to merge 1 commit intoDevExpress:26_1from
aleksei-semikozov wants to merge 1 commit intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the “scroll to edited/created appointment” behavior from the AppointmentPopup layer into the Scheduler widget, so the Scheduler owns the post-save scrolling behavior.
Changes:
- Added
Scheduler.scrollToAppointment(...)and invoke it after successful add/update from the popup save callback. - Removed popup-side “last saved edit data” state and the popup-driven scroll update logic.
- Added a Jest test to verify scrolling occurs after saving from the appointment popup.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/m_scheduler.ts | Adds centralized scroll-to-appointment logic in Scheduler and hooks it into popup save flows. |
| packages/devextreme/js/__internal/scheduler/appointment_popup/m_popup.ts | Removes popup-managed scroll behavior and related state, leaving save flow focused on validation + persistence. |
| packages/devextreme/js/__internal/scheduler/tests/scheduler.test.ts | Adds coverage to ensure saving from the popup triggers scrolling to the appointment position. |
| packages/devextreme/js/__internal/scheduler/tests/mock/create_appointment_popup.ts | Updates the popup test mock surface to reflect removal of scroll update plumbing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.