Slight Optimization for finding lowest F Cost.#6
Open
JBobda wants to merge 1 commit intoDevonCrawford:masterfrom
Open
Slight Optimization for finding lowest F Cost.#6JBobda wants to merge 1 commit intoDevonCrawford:masterfrom
JBobda wants to merge 1 commit intoDevonCrawford:masterfrom
Conversation
… sort method to the sort class to make the find lowest F cost method more efficient. I should have probably just fixed your quicksort method... but I didn't know that off the top of my head so I just went with selection sort. Lel. Also... 8 space tabs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, came from your YouTube video about this project. I've been a long time fan of your channel and I thought that I could contribute something so here you go! This is my first Pull Request so if I am missing something please let me know, but I wanted to start on something easy so I could get into the process of contributing to other people's repositories.
-Removed some unnecessary imports
-Added Selection sort to the Sort class
-Changed lowest F Cost method to use selection sort rather than bubble sort because selection is technically more efficient.