Skip to content

Conversation

@gilesknap
Copy link
Contributor

For projects that have not been updated for a long time I found the documented workflow helped avoid confusion of changing the template and tool versions simultaneously.

@gilesknap gilesknap requested a review from coretl November 18, 2024 14:15
@GDYendell
Copy link
Contributor

Did just updating dependencies and fixing before doing the update make it easier in some case? I always just update and fix everything in one go.

@gilesknap
Copy link
Contributor Author

Did just updating dependencies and fixing before doing the update make it easier in some case? I always just update and fix everything in one go.

So my assertion is that if there is a long break between updates. Having both new ruff (or other) errors to contend with and the changes themselves was too much.

I guess this came about because I was updating to latest from an early beta version of copier template.

When the checks don't even run because of fundamental issues (in my case a missing _version.py) then it's difficult to know where the problem is coming from.

Perhaps I'm over thinking this though. I guess fixes for both causes of error can be performed together. My particular scenario was extreme.

I'm reasonably happy to close without merging.

Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash and merge?

@coretl
Copy link
Contributor

coretl commented Nov 20, 2024

I disabled it for the repo as we sometimes adopt from a branch and squashing loses the update ability. This doesn't apply here, so will re-enable it just for this PR...

@coretl coretl merged commit 36eb592 into main Nov 20, 2024
12 checks passed
@coretl coretl deleted the doc-workflow branch November 20, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants