Skip to content

Conversation

@coretl
Copy link
Contributor

@coretl coretl commented Sep 25, 2025

This will normally be done by pre-commit or the devcontainer when people make a project from the copier template, but we need to do it manually here

@coretl coretl changed the title Run uv sync before pushing example code fix: run uv sync before pushing example code Sep 25, 2025
@coretl coretl force-pushed the example-test branch 7 times, most recently from 3386f1e to d0f3711 Compare September 25, 2025 15:52
@coretl coretl marked this pull request as ready for review September 25, 2025 16:00
@coretl coretl changed the title fix: run uv sync before pushing example code fix: run uv lock before pushing example code Sep 25, 2025
Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we also want this to be done by a precommit/devcontainer shall we put it in a script so it is the same everywhere and doesn't need to be maintained in two places?

Also I am a bit disappointed that there isn't just a uv init command that does most of this...?

@coretl
Copy link
Contributor Author

coretl commented Sep 26, 2025

If we also want this to be done by a precommit/devcontainer shall we put it in a script so it is the same everywhere and doesn't need to be maintained in two places?

Also I am a bit disappointed that there isn't just a uv init command that does most of this...?

All that the devcontainer needs to do is uv sync. The same for pre-commit. The only issue for the example template is that both of those require building the module, which setuptools_scm requires is in a git repo. Hence the annoying stages here...

@coretl coretl merged commit c8fc7b7 into main Sep 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants