Add support for inline comments in regex #238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change _handle_comment to support new regex - src/configobj/__init__.py
jelmer
requested changes
Sep 17, 2024
Collaborator
jelmer
left a comment
jelmer
left a comment
There was a problem hiding this comment.
Can you add some tests for the new behaviour?
- Removed ConfigObjPHP class. - Expanded test cases for handling inline comments with both # and ; markers. - Adjusted assertions to include multiple comment styles (hashtag and semicolon).
Author
|
Yes, tests for the new behavior have already been added. The test cases now include handling of both # and ; inline comment markers, as well as validation of multiple comment styles in configuration sections. |
Collaborator
|
Thanks, I'll take a look at this as soon as we get another release out. |
Contributor
|
If #262 is merged, this PR may need some tweaks in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for inline comments in regex
Change _handle_comment to support new regex