Skip to content

[DRAFT] OPTIMIZE API CALL ON MULTIPLE ADD: As Frances, I want the API to be optimized, so that my interactions are faster when I add a record to multiple stories #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
richardmatthewsdev wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[DRAFT] OPTIMIZE API CALL ON MULTIPLE ADD: As Frances, I want the API to be optimized, so that my interactions are faster when I add a record to multiple stories #273

richardmatthewsdev wants to merge 10 commits into from

Conversation

@richardmatthewsdev
Copy link
Contributor

@richardmatthewsdev richardmatthewsdev commented Oct 19, 2021

Acceptance Criteria

  • One API call only is made when adding/removing to multiple stories at once

Notes

EdwinRozario
EdwinRozario reviewed Oct 21, 2021
View reviewed changes
app/policies/supplejack_api/user_set_policy.rb
end

alias update? admin_or_owner?
alias multiple_add? admin_or_owner?
Copy link
Contributor

@EdwinRozario EdwinRozario Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs for this new policies?

@paul-mesnilgrente paul-mesnilgrente changed the title OPTIMIZE API CALL ON MULTIPLE ADD: As Frances, I want the API to be optimized, so that my interactions are faster when I add a record to multiple stories [DRAFT] OPTIMIZE API CALL ON MULTIPLE ADD: As Frances, I want the API to be optimized, so that my interactions are faster when I add a record to multiple stories May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielaboost danielaboost danielaboost approved these changes

+1 more reviewer

@EdwinRozario EdwinRozario EdwinRozario approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardmatthewsdev @EdwinRozario @danielaboost