Skip to content

Allow seeing all of the facets that have no value #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
richardmatthewsdev merged 4 commits into from
Feb 12, 2025
Merged

Allow seeing all of the facets that have no value #380

richardmatthewsdev merged 4 commits into from
Feb 12, 2025

Conversation

@richardmatthewsdev
Copy link
Contributor

@richardmatthewsdev richardmatthewsdev commented Jan 29, 2025

When passing &facet_missing=true see blank facets in the response, eg

    "facets": {
      "instrument_type": {
        "Existing Facet": 11,
        "": 42
      }

@github-actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

Code quality score

Uh oh! The code quality got worse for this PR! Better take a look!! 🚨

Ruby file count Similarity score (flay) ABC complexity (flog) Code smells (reek) TOTALS
base 141 3.26 8.08 22.25 33.59
this branch 141 3.31 8.16 22.3 33.77
difference 0 ⚠️ 0.05 ⚠️ 0.08 ⚠️ 0.05 0.18

@richardmatthewsdev
fix(filter-missing): Allow using the exclude filters from facets feat…
1d4d95c 
…ure with nil queries

description body

references (Optional)
@richardmatthewsdev richardmatthewsdev merged commit 076db72 into main Feb 12, 2025
3 of 5 checks passed
@richardmatthewsdev richardmatthewsdev deleted the rm/facet-missing branch February 12, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lunmanlee lunmanlee lunmanlee approved these changes

@eoin-boost eoin-boost eoin-boost approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardmatthewsdev @lunmanlee @eoin-boost