Skip to content

Query records by internal identifier #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardmatthewsdev merged 3 commits into from
Feb 13, 2025
Merged

Query records by internal identifier #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
099ac5f
feat(query-by-internal-identifier): Remove turning the id into an int…
richardmatthewsdev Feb 11, 2025
02361e9
Merge branch 'main' into rm/query-by-internal-identifier
richardmatthewsdev Feb 12, 2025
42f2d2a
Remove test as it is no longer required
richardmatthewsdev Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/supplejack/record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,6 @@ def find(id_or_array, options = {})
response['records'].map { |attributes| new(attributes) }
else
begin
# handle malformed id's before requesting anything.
id = id_or_array.to_i
raise(Supplejack::MalformedRequest, "'#{id_or_array}' is not a valid record id") if id <= 0

# Do not send any parameters in the :search key when the user didn't specify any options
# And also always send the :fields parameter
#
Expand All @@ -150,7 +146,7 @@ def find(id_or_array, options = {})
options[:fields] = options[:search].delete(:fields)
options.delete(:search) unless any_options

response = get("/records/#{id}", options)
response = get("/records/#{id_or_array}", options)
new(response['record'])
rescue RestClient::ResourceNotFound
raise Supplejack::RecordNotFound, "Record with ID #{id_or_array} was not found"
Expand Down
4 changes: 0 additions & 4 deletions spec/supplejack/record_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,6 @@ module Supplejack
expect { SupplejackRecord.find(1) }.to raise_error(Supplejack::RecordNotFound)
end

it 'raises a Supplejack::MalformedRequest' do
expect { SupplejackRecord.find('replace_this') }.to raise_error(Supplejack::MalformedRequest)
end

it 'requests the record from the API' do
allow(SupplejackRecord).to receive(:get).with('/records/1', { fields: 'default' }).and_return({ 'record' => {} })

Expand Down
Loading