[Animal Husbandry] Handle null produces, and allows overriding feather/wool/feet drop #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animal Multiproduce removes the deluxe produce from Ducks and Rabbits, causing
GetProduceIDto returnnulland causing butchered Ducks and Rabbits to throw an NRE. This fixes the issue by adding a fallback to vanilla items, and also adds the ability to manually specify custom feather/wool/feet drop for modded animals that can potentially be supported by Animal Multiproduce (though right now I believe you can't specify modded animals that drop feather/wool on butchering? Let me know if that that's in scope for a future PR, and/or more custom drops like leather/bones/etc.)