Refactor SDK generation to support optional codegen. #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce conditional logic to handle SDK generation on nitro size based on whether codegen is enabled or not. When enabled, SDKs are imported as modules; otherwise, mock templates are used as before. This fixes issues with missing fragments on server(nitro) side. Diizzayy#333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for this library!
I faced with missing fragments issue on nitro side and investigated it a bit.
I could suggest the possible simple solution for cases when codegen is enabled.
Introduced conditional logic to handle SDK generation on nitro side based on whether codegen is enabled or not.
When enabled, SDKs are imported as modules from codege generated sdk.
Otherwise, mock templates are used as before.
It fixes issues with missing fragments on server(nitro) side.
#333