Conversation
… including - data fetching, loading states, pagination, and search function
|
Excellent work on implementing core user functionalities. Well done. |
|
Thank you.
Fatima Modupe Bello
Software Engineer [Frontend, React]
GitHub: github.com/techietee
Portfolio: techietee.netlify.app
…On Mon, 27 Jan 2025 at 12:15 PM, iDev10 ***@***.***> wrote:
Excellent work on implementing core user functionality. Well done.
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM7KV6ZOAHTID73Y7PWAL6L2MYINTAVCNFSM6AAAAABVWJQ7R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJVGQ3TKMRUGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
src/index.css
Outdated
| line-height: 1.5; | ||
| font-weight: 400; | ||
|
|
||
| color-scheme: light dark; |
There was a problem hiding this comment.
Good job so far. Your dark mode wasnt setup properly to suit modern design guidelines.
There was a problem hiding this comment.
Done. CSS for dark mode is properly setup
src/components/Layout.tsx
Outdated
| {/* footer */} | ||
| <footer className="bg-gray-800 text-white"> | ||
| <div className="flex items-center justify-center container mx-auto py-4 px-4 md:px-8 text-center"> | ||
| <p className="text-sm">© 2025 Delivva. All rights reserved.</p> | ||
| <img src={Image.delivavLogo} alt="delivva-logo" className="h-4 w-4 mx-2" /> | ||
| </div> | ||
| </footer> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Your footer seem quite empty. Would have loved to see you build a 3 column text layout.
There was a problem hiding this comment.
Done. built a three column text layout on footer
src/pages/Product.tsx
Outdated
|
|
||
| const Product = () => { | ||
| const location = useLocation(); | ||
| const user = location.state?.user; |
There was a problem hiding this comment.
You did not exhust the use of all the Users available data such as rendering the user users image, DOB, etc.
There was a problem hiding this comment.
Done. I am currently displaying all user insensitive data
src/pages/Product.tsx
Outdated
|
|
||
| const Product = () => { | ||
| const location = useLocation(); | ||
| const user = location.state?.user; |
There was a problem hiding this comment.
You did not exhaust the use of all the Users available data such as rendering the user users image, DOB, etc.
|
Thank you for the review, I will make the necessary updates and submit an updated pull request before the close of the day. |
You are welcome. |
… footer, displays all user insensitive available data on details page
|
I have fixed all existing issues. |
3 participants
In this branch are functions that allow users to search, and paginate through a list of users fetched from an external API. It features dynamic navigation, enabling users to view detailed information about a selected user on a product page. The project uses react-router-dom for routing.