fix bug in merge_kernel for structural_reparam #59
Open
liyiersan wants to merge 3 commits intoDingXiaoH:mainfrom
Open
fix bug in merge_kernel for structural_reparam #59liyiersan wants to merge 3 commits intoDingXiaoH:mainfrom
liyiersan wants to merge 3 commits intoDingXiaoH:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying model.structural_reparam(), there is a need to add padding so that the output size can match, see #48.
Besides, I find that the kernel_size, stride, padding, and dilation may be tuples.
Therefore, we need to convert the tuple to int to make DepthWiseConv2dImplicitGEMM work, or it would be replaced with nn.Conv2d.