add bundle.identifier to Dioxus.toml templates#58
Open
liigo wants to merge 1 commit intoDioxusLabs:mainfrom
Open
add bundle.identifier to Dioxus.toml templates#58liigo wants to merge 1 commit intoDioxusLabs:mainfrom
liigo wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
which is required to use Wix bundle tool on windows.
This was referenced Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which is required to use Wix bundle tool on windows.
( The above output is swallowed by tauri-bundler crate, or by candle.exe of Wix. You must run candle.exe manually to get that error. see DioxusLabs/dioxus#3233 )
The Product/@Manufacturer comes from BundleSettings.publisher, which in turn comes from BundleSettings.identifier as fallback. See also the source https://docs.rs/crate/tauri-bundler/2.0.4/source/src/bundle/windows/msi/mod.rs#575-578