Merged
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Contributor
|
The MSRV has been lowered back to 1.88. Therefore, it might make sense to wait for rfd 0.17.2. See PolyMeilex/rfd#303. |
Contributor
Author
|
Yes, although it looks like the immediate issue has been resolved upstream. So we can probably defer this to 0.8.0 (at which point the MSRV bump is probably fine). |
Member
|
It looks like the apt cache action we are using is flakey. Last run failed to load the cache and silently continued to the next step, but it looks like it is doing better after resetting the cache |
ealmloff
approved these changes
Jan 14, 2026
Member
ealmloff
left a comment
ealmloff
left a comment
There was a problem hiding this comment.
Looks like this works with the current msrv after the new minor version of rfd, so this should be good for 0.7.3? It doesn't seem like the ashpd patch fixed things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps MSRV to 1.90 which is non-ideal for a patch release. But currently the Dioxus Desktop build is completely broken on linux.