Open
Conversation
-Fix CObject::Find reference counter remaining unreleased -Cross plugin structs are now initializing with default values -Apply a crash prevention patch to common.dll -Apply a minor optimization to server.dll -Unordered_map and _set are now included in FLCoreServer.h -Added missing dependency to HookExtension plugin for BountyHunt -FLHook core can now compile in debug mode. -Minor optimizations
dsyalex
requested changes
Dec 5, 2023
| <ClCompile> | ||
| <AdditionalOptions>-D_SCL_SECURE_NO_WARNINGS %(AdditionalOptions)</AdditionalOptions> | ||
| <Optimization>Full</Optimization> | ||
| <Optimization>Disabled</Optimization> |
| CShip* cobj = reinterpret_cast<CShip*>(CObject::Find(iShip, CObject::CSHIP_OBJECT)); | ||
| if (cobj) | ||
| { | ||
| cobj->Release(); |
Member
There was a problem hiding this comment.
Shouldn't this be called after we've got the result of GetOwnerPlayer and have actually stopped using the cobj object?
| ReadProcMem(pAddress, szRepFreeFixOld, 5); | ||
| WriteProcMem(pAddress, szNOPs, 5); | ||
|
|
||
| // jump past a redundant XOR statement |
|
|
||
| WriteProcMem(pAddress, szDivertJump, 1); | ||
|
|
||
| // jump out of the crash trap in TradeLane/SPObjUpdate related code |
Member
There was a problem hiding this comment.
are these tricks of our own or things we've gotten from adoxa/tsp friends?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fix CObject::Find-fetched object reference counters remaining unreleased once we're done with them
-Cross plugin structs are now initializing with default values
-Apply a crash prevention patch to common.dll
-Apply a minor optimization to server.dll
-Unordered_map and _set are now included in FLCoreServer.h
-Added missing dependency to HookExtension plugin for BountyHunt
-FLHook core can now compile in debug mode.
-Minor optimizations