POB: Optimizations to damage-taking code, other updates#356
Open
Aingar wants to merge 2 commits intoDiscoveryGC:masterfrom
Open
POB: Optimizations to damage-taking code, other updates#356Aingar wants to merge 2 commits intoDiscoveryGC:masterfrom
Aingar wants to merge 2 commits intoDiscoveryGC:masterfrom
Conversation
-POBs now calculate wear and tear much more efficiently -Fix specific interactions with MobileDocking plugin -Fix players who logged out in space being beamed back onto the POB -POBs now explode immediately upon reaching 0 health -Removed a bunch of deprecated siege-mode related code -Fixed price update logging -Non-crew POB population added to F9 menu and /base supplies -Code cleanup
dsyalex
requested changes
Dec 5, 2023
| pub::SpaceObj::SetRelativeHealth(space_obj, base->base_health / base->max_base_health); | ||
|
|
||
| base->baseCSolar = (CSolar*)CObject::Find(space_obj, CObject::CSOLAR_OBJECT); | ||
| base->baseCSolar->Release(); |
Member
There was a problem hiding this comment.
uh we should not be calling release on something we just shoved into our object
dsyalex
requested changes
Dec 5, 2023
| return curr_hitpoints - damageTaken; | ||
| if (!wasDamagedSinceLastUpdate) | ||
| { | ||
| base->baseCSolar->set_hit_pts(base->base_health); |
Member
There was a problem hiding this comment.
Shouldn't we be doing this after we modify base->base_health below?
|
|
||
| return true; | ||
| } | ||
| else if (args.find(L"basedespawn") == 0) |
Member
There was a problem hiding this comment.
Aren't people using this? Did you mean to get rid of one of the baserespawn handlers instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-POBs now calculate wear and tear much more efficiently
-Fix specific interactions with MobileDocking plugin
-Fix players who logged out in space being beamed back onto the POB
-POBs now explode immediately upon reaching 0 health
-Removed a bunch of deprecated siege-mode related code
-Fixed price update logging
-Non-crew POB population added to F9 menu and /base supplies
-Code cleanup