Skip to content

RS-20085: Only set rhtmlwidget-status to ready once images have loaded#133

Merged
JustinCCYap merged 3 commits intomasterfrom
RS-20085
Nov 6, 2025
Merged

RS-20085: Only set rhtmlwidget-status to ready once images have loaded#133
JustinCCYap merged 3 commits intomasterfrom
RS-20085

Conversation

@JustinCCYap
Copy link
Contributor

@JustinCCYap JustinCCYap commented Nov 6, 2025 •
edited
Loading

Only set the rhtmlwidget-status to ready once images have loaded using promises.

@JustinCCYap JustinCCYap requested a review from Copilot November 6, 2025 03:05
Copilot AI reviewed Nov 6, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@JustinCCYap JustinCCYap requested a review from chschan November 6, 2025 04:13
@JustinCCYap
Copy link
Contributor Author

JustinCCYap commented Nov 6, 2025 •
edited
Loading

Verified on reusdev

@JustinCCYap JustinCCYap merged commit 91e17e7 into master Nov 6, 2025
2 checks passed
@JustinCCYap
Copy link
Contributor Author

JustinCCYap commented Nov 6, 2025

Still not sure why Pictographs suddenly needed this. rhtmlCombinedScatter still exports custom images fine, and I don't think it had special logic to wait for the images to load.

JustinCCYap added a commit that referenced this pull request Nov 7, 2025
@JustinCCYap
Revert "RS-20085: Only set rhtmlwidget-status to ready once images ha…
4091c89 
…ve loaded (#133)"

This reverts commit 91e17e7.
JustinCCYap added a commit that referenced this pull request Nov 10, 2025
@JustinCCYap
Reapply "RS-20085: Only set rhtmlwidget-status to ready once images h…
2d226f7 
…ave loaded (#133)"

This reverts commit 4091c89.
@JustinCCYap JustinCCYap mentioned this pull request Nov 10, 2025
Merged
JustinCCYap added a commit that referenced this pull request Nov 10, 2025
@JustinCCYap
RS-20085: Only set rhtmlwidget-status to ready once images have loaded (
25b3fc9 
#135)

* Reapply "RS-20085: Only set rhtmlwidget-status to ready once images have loaded (#133)"

This reverts commit 4091c89.

* Fix

* inst changes

* Render variable image after base image

* Fix

* Add logging

* Diagnostic

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chschan chschan chschan approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JustinCCYap @chschan