RS-21330: Fix label size measurement broken by flex body in new UI#137
Merged
JustinCCYap merged 4 commits intomasterfrom Mar 11, 2026
Merged
RS-21330: Fix label size measurement broken by flex body in new UI#137JustinCCYap merged 4 commits intomasterfrom
JustinCCYap merged 4 commits intomasterfrom
Conversation
Contributor
Author
|
You can test this out in reusdev at the moment (might need hard refresh of the page after recalculating) |
Use position:fixed;width:max-content instead of display:inline-block so the measurement div is unaffected by flex/grid parent layouts (e.g. the new UI sets body to display:flex) and immune to global width rules that could skew the measured label dimensions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Remember to bump version and update flipStandardCharts |
Contributor
Author
What needs to be updated in flipStandardCharts? |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
You're right, flipStandardChart doesn't refer to a version so it should be fine to just get it updated on nixR/r-server |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bodyhasdisplay:flex(previouslydisplay:block), causing any direct child div to become a flex item and stretch to fill the full widthcalculateLabelDimensionsinlabelUtils.jsappends a measurement div directly todocument.body, so its width was being measured incorrectly (too wide), causing label positions to overflow and the pictograph to render blankposition:fixed;visibility:hiddento the measurement div so it is taken out of the flex flow and measures its natural content sizeTest plan
Fixes: https://numbers.atlassian.net/browse/RS-21330
🤖 Generated with Claude Code