Open
Conversation
Contributor
ororopickpocket
left a comment
ororopickpocket
left a comment
There was a problem hiding this comment.
Looks good so far. Is the APR already set to 5% at this point? and the reward manager to exchequer? is there a script for it?
Contributor
Author
Yes, The APR will be set at the contract initialization of community issuance, as well as the reward manager address right after it. |
ororopickpocket
approved these changes
Apr 26, 2023
tjcloa
requested changes
Apr 26, 2023
Contributor
tjcloa
left a comment
tjcloa
left a comment
There was a problem hiding this comment.
pls use hh sip scripts
otherwise it is pretty hard to do QA testing
Contributor
Author
Added sip scripts for HH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.