Conversation
add sip args add on-chain test
ran prettier
|
|
||
| event CSOVReImburse(address from, uint256 CSOVamount, uint256 reImburseAmount); | ||
| event CSOVTokensExchanged(address indexed caller, uint256 amount); | ||
| contract VestingRegistry is VestingRegistryStorage { |
There was a problem hiding this comment.
pls add natspec - clear description of the purpose of this contract
tests/Locked/anyone.test.js
Outdated
| ); | ||
|
|
||
| vestingRegistry = await VestingRegistry.new(); | ||
| vesting = await VestingRegistryProxy.new(); |
There was a problem hiding this comment.
| vesting = await VestingRegistryProxy.new(); | |
| vestingRegistryProxy = await VestingRegistryProxy.new(); |
tests/Locked/event.test.js
Outdated
| creator // This should be Governance Timelock Contract. | ||
| ); | ||
| vestingRegistry = await VestingRegistry.new(); | ||
| vesting = await VestingRegistryProxy.new(); |
There was a problem hiding this comment.
| vesting = await VestingRegistryProxy.new(); | |
| vestingRegistryProxy = await VestingRegistryProxy.new(); |
tests/Locked/state.test.js
Outdated
| ); | ||
|
|
||
| vestingRegistry = await VestingRegistry.new(); | ||
| vesting = await VestingRegistryProxy.new(); |
There was a problem hiding this comment.
| vesting = await VestingRegistryProxy.new(); | |
| vestingRegistryProxy = await VestingRegistryProxy.new(); |
tests/staking/ExtendedStakingTest.js
Outdated
| // Upgradable Vesting Registry | ||
| vestingRegistryLogic = await VestingRegistryLogic.new(); | ||
| vestingRegistry = await VestingRegistry.new(); | ||
| vesting = await VestingRegistryProxy.new(); |
There was a problem hiding this comment.
| vesting = await VestingRegistryProxy.new(); | |
| vestingRegistryProxy = await VestingRegistryProxy.new(); |
tests/staking/PauseStaking.test.js
Outdated
| // Upgradable Vesting Registry | ||
| vestingRegistryLogic = await VestingRegistryLogic.new(); | ||
| vestingRegistry = await VestingRegistry.new(); | ||
| vesting = await VestingRegistryProxy.new(); |
There was a problem hiding this comment.
pls replace all the occurences in the tests for better readability
| vesting = await VestingRegistryProxy.new(); | |
| vestingRegistryProxy = await VestingRegistryProxy.new(); |
| import "../governance/Vesting/VestingRegistry.sol"; | ||
|
|
||
| contract VestingRegistryLogicMockup is VestingRegistryLogic { | ||
| contract VestingRegistryMockup is VestingRegistry { |
There was a problem hiding this comment.
pls also rename the contract file
tests/OriginInvestorsClaim.test.js
Outdated
| }); | ||
|
|
||
| it("should create vesting contract within vesting period", async () => { | ||
| it("should be able to sert investor initial amount list", async () => { |
There was a problem hiding this comment.
looks like a typo in the test description.
There was a problem hiding this comment.
also, the test does nothing, pls check the removed tests.
There was a problem hiding this comment.
Apparently, we need to update the OriginInvestorsClaim contract (because initially it was using cliff & duration from staking contract), meanwhile when trying to get the vesting, it's using the cliff & duration from lockedSOV
updated in this commit
tests/OriginInvestorsClaim.test.js
Outdated
| investorsClaim.claim({ from: investor1 }), | ||
| "OriginInvestorsClaim::onlyWhitelisted: not whitelisted or already claimed" | ||
| ); | ||
| it("investors should be able to claim", async () => { |
There was a problem hiding this comment.
this test was inverted - why?
2 participants
No description provided.