Open
Conversation
tjcloa
reviewed
Dec 18, 2024
hardhat/tasks/sips/args/sipArgs.js
Outdated
| return { args, governor: "GovernorOwner" }; | ||
| }; | ||
|
|
||
| const getArgsSIP0085 = async (hre) => { |
Contributor
There was a problem hiding this comment.
getArgsSIP0085 has been used
Suggested change
| const getArgsSIP0085 = async (hre) => { | |
| const getArgsSIP0086 = async (hre) => { |
tjcloa
requested changes
Dec 24, 2024
|
|
||
| const basketManagerProxy = await get("BasketManagerV3_Proxy"); | ||
| const newBasketManagerImpl = await get("BasketManagerV3_Implementation"); | ||
|
|
Contributor
There was a problem hiding this comment.
missing targetOwnerValidationAddresses.
although might seem not be necessary rn, still worth checking just in case if it takes longer than expected to create SIPs and the owners will change.
hardhat/tasks/sips/args/sipArgs.js
Outdated
| return { args, governor: "GovernorOwner" }; | ||
| }; | ||
|
|
||
| const getArgsSIP0085 = async (hre) => { |
tests-onchain/sip0085.test.js
Outdated
| }; | ||
| }); | ||
|
|
||
| describe("SIP-0085 Test creation and execution", () => { |
Contributor
There was a problem hiding this comment.
pls replace all SIP-0085 mentions with SIP-0086 because SIP-0085 has been used already
tjcloa
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.