Added a Custom Exception and supporting tests if a model file is not found. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…found. This should satisfy #1
DivineOmega
requested changes
Apr 1, 2021
Owner
DivineOmega
left a comment
DivineOmega
left a comment
There was a problem hiding this comment.
This looks great. Thank you.
Could you also add this to the predict method in the same way please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there, Here is a pull request that adds a custom exception if the Model Data file is not found, and it uses the Flare Custom Solutions API to suggest the command to run to fix the problem.
I've included a test of an Untrained model also, just as a quick way to get the exception to throw.
https://flareapp.io/docs/solutions/adding-custom-solutions
Hope this helps!