Skip to content

Conversation

@BaptisteLam
Copy link

Description

<-- short description of the template(s) and/or reason for update -->

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

Example variable values

<-- to make review process easier please provide example set of variable values for this template -->

<-- Example: -->

var1: aaa
var2: foo.com

<-- Or provide the whole testData object from the Online Editor after testing and using "Add as test" button -->

"testData": {
    "testset": {
      "variables": {
        "domain": "example.com",
        "host": "foo",
        "example": "bar"
      },
      "results": [
        {
          "type": "TXT",
          "name": "foo",
          "ttl": 86400,
          "data": "\"bar\""
        }
      ]
    }
  }

@github-actions
Copy link

Linter error:

Linter result for builtbymagellan.com.websitehosting.json
{"level":"error","template":"builtbymagellan.com.websitehosting.json","groupid":"website","record":0,"type":"CNAME","code":"DCTL1012","dctl_note":"record host must not be @ when template hostRequired is false","time":1765653401}

@kerolasa
Copy link
Collaborator

It looks like patch-3 works without validator complaning. Could you force push that commit to this review branch?

@kerolasa
Copy link
Collaborator

It looks like patch-3 works without validator complaning. Could you force push that commit to this review branch?

As a matter of fact, these is already separate pull about the patch-3: #683

I will close these two in favour of the pull 683.

@kerolasa kerolasa closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants