Add settings page #1015
Add settings page #1015
Conversation
Isak-Kallini
force-pushed
the
new-design
branch
from
05e6fff to
8eeb225
Compare
Isak-Kallini
force-pushed
the
settings-page
branch
from
3e73c3a to
5fe9a1e
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Isak-Kallini
force-pushed
the
settings-page
branch
from
94258e3 to
854d053
Compare
ManneG
left a comment
ManneG
left a comment
There was a problem hiding this comment.
Other than my comments, looks good!
| onValueChange={(value) => setMode(value as "dark" | "light" | "system")} | ||
| > | ||
| <Select.Trigger class="w-36" | ||
| >{modeTranslation(data.theme)}</Select.Trigger |
There was a problem hiding this comment.
This only says "Dark" for me, even when selecting system or light (it changes the page successfully though)
There was a problem hiding this comment.
Unclear how language priority works. Here I set my language to english but then navigated to the swedish path /settings and it shows me swedish
There was a problem hiding this comment.
One proposal for how it could work is, add a third "language option" being "no preference". This would be the default. If you have selected a preference it would (using a hook) always redirect you to the part of the site with you language of choice. This would then also hide the language button in the header as that would be redundant and do nothing.
Selecting english, and then going to /news would then redirect you to /en/news unless you went back to settings and selected no preference
Waiting for switch component