1049 uggo access gui #1053
Merged
1049 uggo access gui #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidagardh
requested changes
Jan 20, 2026
Contributor
davidagardh
left a comment
davidagardh
left a comment
There was a problem hiding this comment.
Nice redesign! See comments for requested code change
| const bgClass = depth % 2 === 0 ? "bg-base-200" : "bg-base-200/60"; | ||
| const isLeaf = !!node.fullPath && Object.keys(node.children).length === 0; | ||
| // faktisk policy |
Contributor
There was a problem hiding this comment.
nits: comments in english
| return root; | ||
| })(); | ||
| function render(node: PolicyNode, depth = 0): string { |
Contributor
There was a problem hiding this comment.
Needs fix: magic html string is not nice for development experience or safety. Rewrite using Svelte snippets or create a component. (A component could maybe be shared between access and positions pages)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mer användbar, not beautiful, but readable.