DYN-9071 Dynamo - DynamoPlayer - SplashScreen Crash #16759
Conversation
This error happens when the user follow the next steps: - open Dynamo. - open DynamoPlayer. - choose a script in player. - close Dynamo and quickly (when the hourglass cursor is still shown) click Dynamo button, then get a crash and the SplashScreen stays frozen. So as a workaround I added some code in Dynamo SplashScreen that will show a messagebox saying that SplashScreen was not initialized correctly, then after the user clicks Ok, then will close the SplashScreen, in this way, we won't get the crash and the SplashScreen will be closed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9071
There was a problem hiding this comment.
Pull request overview
This PR addresses a crash that occurs in Dynamo's SplashScreen when rapidly reopening Dynamo after using DynamoPlayer. The fix adds defensive null checking for the viewModel and displays an informative error message instead of crashing, then closes the splash screen gracefully.
Key Changes:
- Added null check for
viewModelinOnRequestStaticSplashScreen()method - Added localized error messages to resource files for the splash screen error scenario
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/DynamoCoreWpf/Views/SplashScreen/SplashScreen.xaml.cs | Added null check for viewModel and error message display in OnRequestStaticSplashScreen method |
| src/DynamoCoreWpf/Properties/Resources.resx | Added localized strings for splash screen error title and message |
| src/DynamoCoreWpf/Properties/Resources.en-US.resx | Added English localized strings for splash screen error title and message |
Files not reviewed (1)
- src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
| MessageBoxImage.Warning | ||
| ); | ||
| }); | ||
| this.Close(); |
There was a problem hiding this comment.
The code continues to execute line 150 (StaticSplashScreenReady?.Invoke()) even after closing the splash screen when viewModel is null. Add a return statement after this.Close() to prevent invoking the event on a closed/invalid splash screen.
| this.Close(); | |
| this.Close(); | |
| return; |
|
This is a GIF showing the implemented behavior. |
Updating MessageBox content
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hi team, do you have any comment about this changes? |
1 participant
Purpose
SplashScreen crashing when having opened DynamoPlayer
This error happens when the user follow the next steps:
So as a workaround I added some code in Dynamo SplashScreen that will show a messagebox saying that SplashScreen was not initialized correctly, then after the user clicks Ok, then will close the SplashScreen, in this way, we won't get the crash and the SplashScreen will be closed.
Declarations
Check these if you believe they are true
Release Notes
SplashScreen crashing when having opened DynamoPlayer
Reviewers
@DynamoDS/eidos
FYIs
@achintyabhat