Fix blocked goal unblocking with dependencies bug

[Copilot]

Fixed a bug in the goal state transition logic where blocked goals with dependencies would transition to incorrect states when unblocked.

Problem

The issue occurred in this scenario:

1. Schedule a blocked goal
2. Add dependencies to that goal
3. Unblock the goal
4. Goal would incorrectly transition to WAITING_FOR_DATE instead of the appropriate state

The root cause was in the _mark_as_unfailed() function, which always set goals to WAITING_FOR_DATE state regardless of their preconditions or date constraints.

Example

# Create a blocked goal with an unachieved dependency
precondition_goal = GoalFactory(state=GoalState.WAITING_FOR_WORKER)
blocked_goal = schedule(noop, blocked=True)
_add_precondition_goals(blocked_goal, [precondition_goal])

# Unblock the goal
unblock_retry_goal(blocked_goal.id)
blocked_goal.refresh_from_db()

# Before fix: blocked_goal.state == WAITING_FOR_DATE (incorrect)
# After fix:  blocked_goal.state == WAITING_FOR_PRECONDITIONS (correct)

Solution

Updated _mark_as_unfailed() to determine the correct state transition based on:

• Future date: WAITING_FOR_DATE (preserves original behavior)
• Current/past date + unachieved preconditions: WAITING_FOR_PRECONDITIONS
• Current/past date + no preconditions: WAITING_FOR_DATE (let normal flow handle transition to WAITING_FOR_WORKER)

Also fixed:

• Prevented waiting_for_failed_count from going negative by adding bounds checking
• Added proper handling for PROCEED failure behavior when goals are unfailed

Testing

Added comprehensive test case test_blocked_goal_with_dependencies_unblock_transitions that covers both scenarios (achieved and unachieved preconditions). All existing tests continue to pass.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.