feat: implement scale-offset and data type casting via codecs#154
Open
d-v-b wants to merge 5 commits intoEOPF-Explorer:mainfrom
Open
feat: implement scale-offset and data type casting via codecs#154d-v-b wants to merge 5 commits intoEOPF-Explorer:mainfrom
d-v-b wants to merge 5 commits intoEOPF-Explorer:mainfrom
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
d-v-b
commented
Apr 2, 2026
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class ScaleOffset(ArrayArrayCodec): |
Contributor
Author
There was a problem hiding this comment.
I did not make a stand-alone library for this codec, because it is so simple.
Contributor
There was a problem hiding this comment.
ok but will it live in zarr-python or will users have to import eopf-geozarr to use the scale_offset?
Contributor
Author
There was a problem hiding this comment.
in the current state users have to import eopf-geozarr, but I don't like that outcome. I will see if we can get this into zarr-python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR defines the scale-offset transformation as a pair of codecs: a
ScaleOffsetcodec, which implements the Zarr V3scale-offsetcodec , and theCastValueRustV1codec fromcast-value.py, which implements the Zarr V3cast_valuecodec. This means float data can be decoded as float, but stored as ints, in a cf- and xarray-independent manner.Right now it's exposed via a boolean parameter to
convert_s2_optimized, and command-line flag--experimental-scale-offset-codec.caveat: downstream consumers will need the
ScaleOffsetandCastValuecodecs available in order to decode the data. We should work on ways to make this straightforward.