Refactor of base classes for svgRenderer to new Positional system #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OssianEPPlus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of previous PR:
Unified commits 8c0ac43 through d351393
From PR Refactor/new svg writer #2233
Commits previous to 8c0ac43 in that PR are already added to develop9 but showed up as new commits. Added all changes manually as a singular commit instead.
Fixed bugs so it no longer breaks svgRenderer
Contents:
Draft of re-factor for base-classes Also adds unimplemented methods to charts
SvgShape base-class "DrawingShape" lacked proper relationship to RenderItem
Started creating a importer for Epplus items in abstract base-classes that become a mix of "DrawingShape" and renderItem
When finished, The structure and position of each shape -> textbody -> paragraphs -> textruns will become abstract and any future file-formats need not re-calculate positions.
Each format will have all wrapped/calculated positions ready to go. And implement "real" classes for the specific format.