Conversation
JanssenBrm
left a comment
There was a problem hiding this comment.
Thank you for updating the branch @sivasanarul! I noticed that a dedicated record.json for gisat. You can find an example in the other PR: https://github.com/ESA-APEx/apex_algorithms/pull/123/changes#diff-7e8ac09cd317024b2958fdf55d4d03df6d6595bba953a3966a35221ccebcb865 . However, the logo links are still missing in that record.
I wanted to provide the update myself, but I'm not able to push changes to your fork.
algorithm_catalog/gisat/sentinel1_changedetection/records/sentinel1_changedetection.json
Outdated
Show resolved
Hide resolved
algorithm_catalog/gisat/sentinel1_changedetection/records/sentinel1_changedetection.json
Show resolved
Hide resolved
algorithm_catalog/gisat/sentinel1_changedetection/records/sentinel1_changedetection.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
It seems that his file only contains the process_graph. A valid UDP should contain an ID, a more comprehensive description and the parameters. Could you share how the UDP definition was generated?
There was a problem hiding this comment.
I have changed the process graph. the latest one is generated from this:
https://github.com/Gisat/dev-S14amazonas/blob/main/apex_generate.py
algorithm_catalog/gisat/sentinel1_changedetection/records/sentinel1_changedetection.json
Show resolved
Hide resolved
|
Thank you for the updates @sivasanarul! I have generated a preview PR where you can see how the record would be shown on the algorithm catalogue:
Although the record is now showing properly in the catalogue, I would like to suggest some minor improvements:
However, the above points are not required in any way. If you feel it is sufficient as-is, let me know, and I will merge the PR. |
|
Hi @JanssenBrm There are some limitations to the algorithm that I would like to mention in the description. I have some urgent work to finish now. I will update this today late afternoon, and monday morning. And then it would be ready for merging |
|
Just to be clear, I need to update the description in the UDP in my forked apex repo and create a new pull request? |
You can update the description in this PR - I will trigger the update in the preview manually for now so that we can keep it simple. |
This pull request contributes a script developed under the Sentinel 1-Amazonas project in gisat. The script processes Sentinel-1 backscatter time-series data by stacking 10 temporal slices and generating a binary change map. It is part of our workflow for detecting land-cover change using Sentinel-1 data.