Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 14, 2025

Description

Enable the annotations ruff rule. This will help with transitioning to fully typed code.

I also enabled to option to automatically add from __future__ import annotations where that is useful, to reduce the number of runtime imports and resulting issues with circular imports.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.55%. Comparing base (89ab5a3) to head (7fb5f5c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
- Coverage   95.63%   95.55%   -0.08%     
==========================================
  Files         263      263              
  Lines       15492    15508      +16     
==========================================
+ Hits        14816    14819       +3     
- Misses        676      689      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela force-pushed the enable-annotations-rule branch 2 times, most recently from d8685af to 4c2ae22 Compare November 21, 2025 10:58
@bouweandela bouweandela force-pushed the enable-annotations-rule branch from 4c2ae22 to 794542a Compare November 21, 2025 11:07
@bouweandela bouweandela marked this pull request as ready for review November 21, 2025 11:22
@bouweandela bouweandela added this to the v2.14.0 milestone Nov 21, 2025
@valeriupredoi valeriupredoi added the enhancement New feature or request label Nov 21, 2025
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd never have enough patience to sort all those compliance changes manually - please merge yourself, I had a look through it, all looks fine, but I didn't go line by line 😁

@bouweandela
Copy link
Member Author

Thanks V! It's not the most inspiring job indeed, but it's really helpful to have those type hints in-place for development, so I think it's worth it.

@bouweandela bouweandela merged commit f7d004d into main Nov 21, 2025
4 checks passed
@bouweandela bouweandela deleted the enable-annotations-rule branch November 21, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants