Fix #1042: Add explicit config setup to authorization unit tests

[stephenredhat]

Describe your changes

This PR resolves inconsistent test behavior in test_authorization.cpp by explicitly setting key configuration values in all authorize_req-related unit tests. Specifically, each test now directly configures:

local_pre_authorize

local_authorize_offline

WebSocket connection status via ON_CALL(...).WillByDefault(...)

These changes ensure that test results are deterministic and isolated from global or default state, as described in issue #1042.

Issue ticket number and link

Fixes #1042
#1042

Checklist before requesting a review

• I have performed a self-review of my code
• I have made corresponding changes to the documentation
• If OCPP 2.0.1 or OCPP2.1: I have updated the OCPP 2.x status document
• I read the contribution documentation and made sure that my changes meet its requirements

[mlitre]

Thanks for picking up this issue! I think there are several other tests where we could be more explicit, such as: validate_token_local_auth_list_enabled_accepted, validate_token_local_auth_list_enabled_unknown_no_remote_authorization, validate_token_local_auth_list_enabled_unknown_websocket_disconnected, validate_token_local_auth_list_enabled_connectivity_manager_connected_accepted, validate_token_emaid_offline_no_certificate_contract_validation_offline_allowed_certificate_valid_no_authorize_offline, validate_token_emaid_offline_no_certificate_contract_validation_offline_allowed_certificate_valid_localauthlistctrlr_enabled, validate_token_emaid_offline_no_certificate_contract_validation_offline_allowed_certificate_expired and validate_token_auth_cache_lifetime_expired.
Once those tests are also updated, I think everything should be good. Please make sure to run clang-format after your modifications, I saw some format changes that could cause issues in the CI.

[stephenredhat]

Hi @mlitre
Thanks for the feedback I've updated all the mentioned tests to explicitly set the relevant configuration values and ran clang-format to fix formatting issues. Also cleaned up the PR to remove unrelated commits. Let me know if anything else is needed.

[mlitre]

Hi @stephenredhat looks good to me, if you could just fix the tests by adding the missing device model argument in some of the calls to set the variables. Thanks!

[stephenredhat]

Hi @mlitre I’ve updated all set_local_pre_authorize and set_local_authorize_offline calls to explicitly include device_model, as suggested. The changes are now committed and pushed. Let me know if there’s anything else you'd like to see. Thanks again for your help!

[mlitre]

Hi @stephenredhat, thanks for taking the time to contribute! The changes look good to me, but could you please fix the issues seen in the CI? I believe there is format error, a dco error (please sign off your commits as per the contributing guidelines) and there seems to be a test that fails, if you could rectify that as well thank you!

[mlitre]

Hi @stephenredhat thanks for updating everything, things look almost perfect now! Could you just take a look at the failing test case and see if there is a fix required in the code or if the test case is wrong?