Change cmake test file so it is possible to add separate unit test executables #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
hikinggrass
requested changes
Jan 20, 2025
Member
There was a problem hiding this comment.
In general we should refactor this a bit to move some of the setup code to functions in a dedicated .cmake, but that doesn't have to happen in this PR
…ecutables. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
force-pushed
the
feature/unit_tests_separate_files
branch
from
ebdee53 to
db31fd0
Compare
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
hikinggrass
reviewed
Jan 20, 2025
tests/libocpp-unittests.cmake
Outdated
| set(oneValueArgs NAME PATH) | ||
| set(options) | ||
| set(multiValueArgs) | ||
| cmake_parse_arguments(arg_libocpp_unittest "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN}) |
Member
There was a problem hiding this comment.
this could just be arg to make the following code more readable
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
hikinggrass
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Until now libocpp always used one big test executable. All tests were linked against the whole libocpp library. That is not always necessary and desirable. With some cmake changes, it is possible to add separate test executables.
I changed the utils_tests so it is created as a separate target instead of inside the default libocpp_unit_tests target, just to make it work and to have an example of how you can do this.
Issue ticket number and link
Checklist before requesting a review