feat: Point to earthbuild #170
Conversation
🎉 Are we earthbuild yet?Great progress! You've reduced "earthly" occurrences by 35 (53.85%) 📈 Overall Progress
📁 Changes by file type:
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
Summary of ChangesHello @gilescope, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant rebranding effort, transitioning the project's references from 'earthly' to 'EarthBuild'. The changes encompass updates to documentation, build configurations, and core source code to align with the new branding and repository structure. It also includes temporary adjustments to the version resolution logic to accommodate the current prerelease status of EarthBuild, with explicit notes for future stabilization. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates most references from earthly to EarthBuild, pointing the action to the new repository. The changes in documentation, source code, and configuration files are mostly consistent with this goal. My review includes feedback on improving documentation consistency, handling temporary test changes more gracefully, and a critical reminder about hardcoded values that affect the action's functionality, which should be addressed before merging.
src/setup.ts
Outdated
| const prerelease = true; | ||
| const range = "v0.8.17-rc-0" |
There was a problem hiding this comment.
These hardcoded values for prerelease and range break the action's configurability via user inputs. While I see the TODO and understand this is for testing a pre-release, this is a significant temporary change. Please ensure this is reverted and the action correctly uses the version and prerelease inputs before this PR is merged.
| jobs: | ||
| tests: | ||
| name: example earthly test | ||
| name: example earthbuild test |
There was a problem hiding this comment.
For branding consistency, it would be better to use EarthBuild (PascalCase) instead of earthbuild (lowercase) throughout the documentation. The official name appears to be EarthBuild based on the repository name, action.yml, and package.json. This change should be applied consistently across the file on lines 34, 38, 41, 47, 50, 77, 79, and 80 as well.
| name: example earthbuild test | |
| name: example EarthBuild test |
| // '*', | ||
| // '^0', | ||
| // '0.*.*', | ||
| // '0.8.*', |
There was a problem hiding this comment.
Instead of commenting out tests, consider using it.skip to temporarily disable them. This makes it clearer that the tests are being skipped intentionally and ensures they don't get forgotten, as test runners typically report skipped tests. This would be a better approach for all the commented-out tests in this file.
Todo before merging:
People should be able to point to this branch / latest commit on this branch to install EarthBuild via actions. (Makes sure prerelease = true is set in the action)
Manual Test works: