Skip to content

Conversation

@kmannislands
Copy link

Fixes #159

The released binaries produced by the new automation do not correctly set the buildkitd image to be used by default.

…r.io in release builds, fix malformed image reference by passing through tag
@gemini-code-assist
Copy link

Summary of Changes

Hello @kmannislands, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug affecting released binaries, where the buildkitd image reference was incorrectly configured. By making the RELEASE_TAG a mandatory argument in the release build process, the change guarantees that the correct image is consistently applied, ensuring the stability and proper functioning of the released artifacts.

Highlights

  • Bug Fix: Addresses an issue where released binaries had a malformed image reference and incorrect Docker registry for the buildkitd image.
  • Build Configuration: Introduces RELEASE_TAG as a required argument in the release/Earthfile to ensure the correct buildkitd image is used during release builds.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci-staging-deploy.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

➖ Are we earthbuild yet?

No change in "earthly" occurrences

📈 Overall Progress

Branch Total Count
main 5735
This PR 5735
Difference +0

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug in the signed-release target within release/Earthfile. By introducing the --required RELEASE_TAG argument, it ensures that release builds properly receive the release tag. Previously, the missing argument caused a malformed image reference for the buildkitd image because the tag was empty. The change is precise, effectively resolves the issue, and makes the release process more robust. The fix looks good.

@gilescope
Copy link

EarthBuild/hello-world#1 - looking forward to this being merged.

@gilescope gilescope marked this pull request as ready for review December 22, 2025 06:44
@gilescope gilescope requested a review from a team as a code owner December 22, 2025 06:44
@gilescope gilescope requested review from janishorsts and removed request for a team December 22, 2025 06:44
@gilescope
Copy link

Let's merge this, create another RC and see where we are.

@gilescope gilescope merged commit 45643e3 into main Dec 22, 2025
93 checks passed
@gilescope gilescope deleted the gh-159-fix-buildkit-version-in-prerelease-staging-test branch December 22, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.8.17-rc-0 cannot fetch the buildkitd container

3 participants