-
Notifications
You must be signed in to change notification settings - Fork 10
bug(#159): Fix malformed image reference, docker registry for buildkitd image in release builds #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(#159): Fix malformed image reference, docker registry for buildkitd image in release builds #192
Conversation
…r.io in release builds, fix malformed image reference by passing through tag
Summary of ChangesHello @kmannislands, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical bug affecting released binaries, where the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a bug in the signed-release target within release/Earthfile. By introducing the --required RELEASE_TAG argument, it ensures that release builds properly receive the release tag. Previously, the missing argument caused a malformed image reference for the buildkitd image because the tag was empty. The change is precise, effectively resolves the issue, and makes the release process more robust. The fix looks good.
|
EarthBuild/hello-world#1 - looking forward to this being merged. |
|
Let's merge this, create another RC and see where we are. |
Fixes #159
The released binaries produced by the new automation do not correctly set the buildkitd image to be used by default.