add renovate and fix ci #3
Conversation
Summary of ChangesHello @gilescope, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Renovate Bot into the repository by adding its foundational configuration. The main purpose is to automate the process of keeping dependencies up-to-date, thereby improving security, reducing technical debt, and ensuring the project leverages the latest features and fixes. A key aspect of this integration is the custom support for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a Renovate configuration file. The configuration is a good starting point, extending best practices. However, I've found a few issues in the manager configurations that would prevent Renovate from working correctly on the Earthfile. Specifically, the managerFilePatterns for both the dockerfile and customManagers are incorrect and will not match the Earthfile. Additionally, the regex in the customManagers is brittle and may fail to detect versions if they are at the end of a line. I've provided suggestions to fix these issues.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| PROJECT earthly-technologies/core | ||
|
|
||
| all: | ||
| BUILD --platform=linux/amd64 --platform=linux/arm64 +test-deep-clone-image \ |
There was a problem hiding this comment.
it is a bit different to not test multi-platform clone.
Did that qemu setup action we use widely in the main repo not do the trick?
| eval $(ssh-agent) | ||
| mkdir -p ~/.ssh | ||
| chmod 700 ~/.ssh | ||
| printf '%s\n' "${{ secrets.EARTHBUILDCI_GITHUB_USER_SSH_PRIVATE_KEY }}" | tr -d '\r' > ~/.ssh/id_ed25519 |
There was a problem hiding this comment.
let's discuss tomorrow and see if we can move this to the app installation and do away with the service account
Same renovate config as actions-setup.
Update CI.
Switched to ed25519, from rsa.