GenericHybrid with DimensionalData and extra_loss function #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing => might be a pre-processing we do for the user
…rameters to 0.5 between min max - hybrid_name fills up the disk space when experiementing - log10 yscale breaks with NSE metric comes from negative to positive
Collaborator
Author
|
Working example in projects/book_chapter/example_synthetic.jl for both |
… IDE has autoformat on save on with with other formatting rules
lazarusA
reviewed
Dec 15, 2025
src/utils/logging_loss.jl
Outdated
|
|
||
| function compute_loss(ŷ, y::AbstractDimArray, y_nan::AbstractDimArray, targets, loss_spec, agg::Function) | ||
| losses = [_apply_loss(ŷ[k], y[col = At(k)], y_nan[col = At(k)], loss_spec) for k in targets] | ||
| losses = [_apply_loss(ŷ[k], y[col=At(k)], y_nan[col=At(k)], loss_spec) for k in targets] |
Member
There was a problem hiding this comment.
in #157 I did use col to match KeyArray syntax, and this will work for now, but note that in general DimArrays / YAXArrays will not have this name. We will need to discuss this further.
Collaborator
Author
There was a problem hiding this comment.
Maybe we just rename whatever the user gives and print something original axis x renamed to row, other axis untouched
lazarusA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra_loss function can be defined like so. Here steering rb to 5