Open
Conversation
for index out of bound if index provided should be larger than array length and in require index should be smaller than array length
kanian
suggested changes
Sep 12, 2023
kanian
left a comment
There was a problem hiding this comment.
It's
if (_index > arr.length - 1) {
return;
}
Let's say arr.length = 6; If you say _index > arr.length, you will get the case where _index = 6, which is clearly out of bounds, but with ( _index > arr.length ) == false;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for index out of bound if index provided should be larger than array length and in require index should be smaller than array length