Fix EIP-681 parsing to accept URIs with unknown contract addresses #323
+99
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation was too conservative with security when handling unknown tokens. Rather than be strict, we only throw an error when currency code or contract address is known and doesn't either the currency code or contract address supplied to `parseUri`.
samholmes
force-pushed
the
sam/eip-681-unknown-contract-fix
branch
from
5a994ec to
8b5dbdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation was too conservative with security when handling
unknown tokens.
Rather than be strict, we only throw an error when currency code or
contract address is known and doesn't either the currency code or
contract address supplied to
parseUri.