Replace secp256k1 library with bigint compatible version #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
force-pushed
the
matthew/bigint-tinysecp256k1
branch
from
965eb17 to
b739d70
Compare
samholmes
approved these changes
Apr 9, 2025
| }, | ||
| "dependencies": { | ||
| "@bitcoin-js/tiny-secp256k1-asmjs": "^2.2.3", | ||
| "@bitcoinerlab/secp256k1": "^1.2.0", |
Contributor
There was a problem hiding this comment.
I wonder if https://github.com/bitcoinjs/tiny-secp256k1 would make more sense. It may be a breaking change because it requires WASM, but how many platforms that support BigInt don't support WASM?
In addition to replacing the library, we're changing how the ECPair library is first instantiated. It's wrapped in a function so that any errors thrown during `initEccLib` can bubble up nicely instead of crashing on launch. Dependencies of edge-currency-plugins, like altcoinjs, already depend on on bigint support so this is not considered a breaking change.
samholmes
force-pushed
the
matthew/bigint-tinysecp256k1
branch
from
b739d70 to
97978f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none