Sam/ecash fixes #434
Merged
Sam/ecash fixes #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
requested changes
May 30, 2025
Contributor
peachbits
left a comment
peachbits
left a comment
There was a problem hiding this comment.
Forcing the cashaddr prefix creates a couple of bugs. First, the address explorer link would need to be updated so there wouldn't be a double "ecash:" in the url. Similarly, encodeUri will create a uri with a duplicated "ecash:" in it so that function would need special handling inside of it.
samholmes
force-pushed
the
sam/ecash-fixes
branch
from
c3a9475 to
e8a6f15
Compare
peachbits
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none