Add retry delay to fix dropped transaction thrashing #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
paullinator
requested changes
Oct 31, 2025
| common.taskCache.transactionUpdateCache[txId] = { | ||
| processing: false | ||
| } | ||
| }, 10000) |
Member
There was a problem hiding this comment.
Seems like a legit issue. The engine needs to keep track of pending setTimeouts and kill them on killEngine
| common.taskCache.transactionUpdateCache[txId] = { | ||
| processing: false | ||
| } | ||
| }, 10000) |
Member
There was a problem hiding this comment.
Added a fixup but not tested. give it a try
Contributor
Author
|
I tested with my additional fixup |
paullinator
approved these changes
Oct 31, 2025
samholmes
force-pushed
the
sam/dropped-tx-thrashing
branch
from
6c8c6a1 to
6cc3bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Adds a 10s retry delay when re-queuing failed transaction updates and manages pending timeouts that are cleared on engine stop.
src/common/utxobased/engine/UtxoEngineProcessor.ts):pendingTimeoutsset and clears all onstop().CommonParamswithpendingTimeoutsand addsaddPendingTimeout()utility.processCheckTransactionConfirmationerror path, re-queuestransactionUpdateCache[txId]after a 10s delay to prevent thrashing.Written by Cursor Bugbot for commit 6cc3bf1. This will update automatically on new commits. Configure here.