Removed ownjsonSerializer from WindowManager#907
Removed ownjsonSerializer from WindowManager#907FlorianRappl merged 1 commit intoElectronNET:developfrom
Conversation
Removed the unneeded serializer and applied the settings to the global this._jsonSerializer as when the X and Y values are -1 in the options it would lead to some settings not being applied. E.g. ContextIsolation with it now applying the default values when serializing, settings mentioned before are correctly assigned on Electron's end
FlorianRappl
left a comment
There was a problem hiding this comment.
LGTM!
Any idea why we might have needed / used the previous behavior on the _jsonSerializer @GregorBiswanger ?
|
(Wrong base branch used - I changed the target to |
The earlier SocketIO libraries didn't have built-in serialization. |
Yes, but why was the behavior set to |
Typically it would be about reducing payloads, but
|
Removed the unneeded serializer and applied the settings to the global this._jsonSerializer as when the X and Y values are -1 in the options it would lead to some settings not being applied. E.g. ContextIsolation with it now applying the default values when serializing, settings mentioned before are correctly assigned on Electron's end
In regards to #906