Finish SaidIt Kotlin migration and port audio helpers #8
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| if (playingPosition == position) { | ||
| releasePlayback() | ||
| playingPosition = null | ||
| } | ||
|
|
||
| playbackSession = null | ||
|
|
There was a problem hiding this comment.
When a user deletes any row, removeEntry unconditionally sets playbackSession = null after the deletion even if another recording is currently playing. The active PlaybackSession keeps running because it is never released, but the adapter has discarded the reference, so subsequent play/pause actions will start a second session while the original audio continues and cannot be stopped by releasePlayer(). The previous Java version only cleared the player when the deleted item was the one playing. Consider only nulling the session after releasing it, or leave it intact when another item is removed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Prevented
RecordingsAdapterfrom clearing the active playback session when deleting a different recording, preserving pause/resume control for the currently playing item. SaidIt/src/main/kotlin/eu/mrogalski/saidit/RecordingsAdapter.ktL146-L154
Testing
⚠️ Tests not run (not requested)
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Summary
simplesoundPCM/DSP helpers into theaudiomodule as Kotlin sources, dropping the legacy jar and wiring in new JVM testsTesting
https://chatgpt.com/codex/tasks/task_b_68e3d0da99788323b99d36fa41518eec