Open
Conversation
Added __PATH_BY_LUA All further commits by me will include __DRESDENJOHN defines to allow for debugging This allows the user to use config.lua in the /lua/ directory to assign the client location.
Removed Self Defines
__VS_COMPILE now active in VersionCommon.h. Still compiles in CMAKE even without VS. Just standardized and cleaned up some parts for VS to compile. SOL Fixing and VS Compatibility coming next
|
Looks good! No more having to have two League installations, one named Riot Games, the other Rito Games, and having to switch them around :) |
|
you should name it Rito Gems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should have done it this way from the start. Sorry guys.
Allows end user to assign league client location via config.lua in /lua/ folder.