update

[xuhuanzy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @xuhuanzy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the type inference mechanism within the emmylua_ls language server, specifically focusing on improving the identification of class types in Lua. It introduces a dedicated utility function to determine if a given LuaType represents a class, including robust handling of union types and preventing deep recursion. This refined class detection logic is integrated into the hover handler to provide more accurate resolution of table fields. A new test case has been added to verify the correct behavior with union types involving nil.

Highlights

• Improved Class Type Detection: A new recursive function, table_is_class, has been introduced to more robustly determine if a LuaType represents a class. This function now correctly handles union types and includes a depth limit to prevent infinite recursion during type resolution.
• Refactored Hover Logic: The resolve_table_field_through_type_inference function in the hover handler has been updated to utilize the new table_is_class function. This ensures more accurate identification of class types when resolving table fields for hover information.
• New Test Case for Union Types: A new test case, test_class_with_nil, has been added to validate that the hover functionality correctly identifies class fields within complex union types that include nil.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request extends hover support to work with fields of union types that include classes. This is achieved by introducing a new helper function table_is_class that can recursively check types within a union. A corresponding test case is added to verify the new functionality. My review identifies a performance issue in the implementation of table_is_class where unnecessary allocations occur in a recursive loop. I've provided a suggestion to optimize this.