Skip to content

Conversation

@SupernaviX
Copy link
Contributor

note that this is a patch to major version 14

@lisicky
Copy link
Contributor

lisicky commented Jul 29, 2025

Hi @SupernaviX ! Could you explain reasons why we need to bump bindgen version ?

@SupernaviX
Copy link
Contributor Author

Hi @lisicky! This is for a midnight-node upgrade; some dependencies force it onto cardano-serialization-lib v14, and others force it onto wasm-bindgen v0.2.100

@TristonJ
Copy link

This would also be useful for my team, where we have other cargo dependencies that depend on wasm-bindgen ^0.2.100 (and our current only alternative is to fork cardano-serialization-lib, or fork those dependencies).

@lisicky
Copy link
Contributor

lisicky commented Aug 23, 2025

Thanks @SupernaviX and @TristonJ for the clarification, I’ll bump it in the next version 15.0.1

@lisicky lisicky added this to the 15.0.1 milestone Aug 23, 2025
@lisicky lisicky marked this pull request as ready for review August 26, 2025 02:33
Copy link
Contributor

@lisicky lisicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@lisicky
Copy link
Contributor

lisicky commented Aug 26, 2025

@SupernaviX @TristonJ I got error "recursion limit reached while expanding #[wasm_bindgen]” with wasm-bindgen 0.2.100 how did you manage it on your side ?

@lisicky lisicky removed this from the 15.0.1 milestone Aug 26, 2025
@TristonJ
Copy link

TristonJ commented Sep 4, 2025

Apologies for the delay @lisicky - I just saw this. I see that you might have sorted it out with the wasm-bindgen team here. I didn't notice the recursion limit issue since we're not actually using WASM/JS right now 😅 (just the Rust bits). Thanks!

@ozgb
Copy link

ozgb commented Nov 3, 2025

Bumping this - would be great to get this merged!

Copy link
Contributor

@lisicky lisicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@lisicky lisicky added this to the 15.0.2 milestone Nov 7, 2025
@lisicky
Copy link
Contributor

lisicky commented Nov 7, 2025

I bumped bindgen version to “0.2.105” , release will be published in 1-2 days if everything will be ok

@lisicky lisicky merged commit 805a7c5 into Emurgo:master Nov 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants