-
Notifications
You must be signed in to change notification settings - Fork 137
Update wasm-bindgen #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wasm-bindgen #736
Conversation
|
Hi @SupernaviX ! Could you explain reasons why we need to bump bindgen version ? |
|
Hi @lisicky! This is for a midnight-node upgrade; some dependencies force it onto cardano-serialization-lib v14, and others force it onto wasm-bindgen v0.2.100 |
|
This would also be useful for my team, where we have other cargo dependencies that depend on |
|
Thanks @SupernaviX and @TristonJ for the clarification, I’ll bump it in the next version 15.0.1 |
lisicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/check
|
@SupernaviX @TristonJ I got error "recursion limit reached while expanding |
|
Bumping this - would be great to get this merged! |
lisicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/check
|
I bumped bindgen version to “0.2.105” , release will be published in 1-2 days if everything will be ok |
note that this is a patch to major version 14