Open
Conversation
me4502
force-pushed
the
mc/26.1
branch
2 times, most recently
from
d7eb0a4 to
995cef9
Compare
Most can be AW or just use existing API now
Closed
SirYwell
reviewed
Apr 5, 2026
| oldState.updateIndirectNeighbourShapes(world, pos, NOTIFY, recursionLimit); | ||
| if (sideEffectSet.shouldApply(SideEffect.EVENTS)) { | ||
| CraftWorld craftWorld = world.getWorld(); | ||
| BlockPhysicsEvent event = new BlockPhysicsEvent(craftWorld.getBlockAt(pos.getX(), pos.getY(), pos.getZ()), CraftBlockData.createData(newState)); |
Contributor
There was a problem hiding this comment.
Suggested change
| BlockPhysicsEvent event = new BlockPhysicsEvent(craftWorld.getBlockAt(pos.getX(), pos.getY(), pos.getZ()), CraftBlockData.createData(newState)); | |
| BlockPhysicsEvent event = new BlockPhysicsEvent(craftWorld.getBlockAt(pos.getX(), pos.getY(), pos.getZ()), newState.asBlockData()); |
This uses caching instead of creating a new instance each time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These track final MC release builds, not builds against pre-release/RCs/etc.
Builds: https://builds.enginehub.org/job/worldedit?branch=mc/26.1