Fix request/response race condition. #232
Open
vglavtchev wants to merge 1 commit intoEricssonResearch:masterfrom
Open
Fix request/response race condition. #232vglavtchev wants to merge 1 commit intoEricssonResearch:masterfrom
vglavtchev wants to merge 1 commit intoEricssonResearch:masterfrom
Conversation
…handled by the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
ctoshandling section of the server, there is a race condition exhibited on some systems. If the response is sent (with the response.end call), sometimes the "data" and "end" callbacks for the body are not called. This results in a loss of the body content and prevents the peer-to-peer connection from being created. This is particularly exhibited when running the server in Node JS on Heroku.